Skip to content

Huge refactoring of language server #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 76 commits into from
Dec 13, 2021
Merged

Huge refactoring of language server #89

merged 76 commits into from
Dec 13, 2021

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Nov 23, 2021

  • moved LSP protocol related stuff into a proper go library
  • allow using the arduino-cli gRPC daemon instead of running barebone cmdline arduino-cli
  • reorganization of the repository
  • cleanup of the sketch rebuild triggering functions
  • better logging
  • a lot of small cleanups

cmaglie added 30 commits November 23, 2021 15:48
@cmaglie
Big refactoring to get rid of all legacy lsp/jsonrpc2 stuff
1942ec4
@cmaglie
removed old LSP lib
99fa3a8
@cmaglie
Renamed INOHandler to INOLanguageServer
2e2166a
@cmaglie
Major improvement in logging
63c7ad1
@cmaglie
Introduced lsp.Client/Server and big improvement in logging
dec44e9
@cmaglie
Reorganized repository
07011ac
@cmaglie
Better isolation of LSPClient/LSPServer
6cceaac
@cmaglie
Handled events 'shutdown' and 'exit'
be08b32
@cmaglie
Made logging color more coherent
270c49c
@cmaglie
Improved progress logging
cfd57dd
@cmaglie
removed dependency
fca69e3
@cmaglie
Load CPP symbols only after adding the file
83860ca
@cmaglie
Renamed fields and improved didChange handling
a82b525
@cmaglie
improved logging and some refactorings
fb4b242
@cmaglie
fix: when rebuilding sketch file send a didSave notification instead …
592b11b 
…of a didChange
@cmaglie
Renamed InoMapper -< SketchMapper
7f463d8
@cmaglie
Addded missing options in ServerCapabilities
14274fa
@cmaglie
Fixed wrong condition in SignatureHelp handler
ccbc0c6
@cmaglie
send DidChange notification together with DidSave
df25ec5
@cmaglie
Added error color in loggin to make errors more visible
0073fd3
@cmaglie
Refactoring of the builder
c8d2e5e
@cmaglie
Do not send full text in didSave notification to clangd
f0a3a30
@cmaglie
Factored initializeWorkbench function
b30c074
@cmaglie
Factored out clang starter
162db7f
@cmaglie
Updating go.mod
ff7d9bd
@cmaglie
Fixed synchronization problem with clangd
98bbd42 
clangd/clangd#717 (comment)
@cmaglie
Moved textutils in lsp package, slightly improved logging
d0c0168
@cmaglie
change go.mod
ad47a52
@cmaglie
BIG REFACTOR: build sketch is triggered on every change
43755fd 
The sketch build may be interrupted if new changes comes during the
build (invalidating it).

Since we auto rebuild on every change we do not need to monitor includes
or symbols anymore greatly reducing code complexity.

Build progress is no more handled by a goroutine, we lose the cycling
dots (. -> .. -> ...) but we simplify the code a lot.

The compile_commands.json is now kept separated from the one created by
the CLI (that is touched multiple times, and it confuses clangd). Now
the compile_commands.json seen by clangd is touched only once after a
successful build.
@cmaglie
Removed outdated launch config
84c418a
@hendrikmennen
Copy link

Great! This fixes #85.
Completion does not seem to work yet, but still very nice to see some progress :)

@per1234 per1234 linked an issue Nov 25, 2021 that may be closed by this pull request
DidChange not working as expected #85
Closed
@cmaglie cmaglie mentioned this pull request Dec 11, 2021
Closed
@cmaglie cmaglie marked this pull request as ready for review December 13, 2021 09:20
@cmaglie cmaglie merged commit 72fc111 into main Dec 13, 2021
@cmaglie cmaglie deleted the megarefactoring branch December 13, 2021 09:23
@per1234 per1234 added the type: enhancement Proposed improvement label Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DidChange not working as expected
3 participants
@cmaglie @hendrikmennen @per1234